-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve SVG exportation #2882
Conversation
Deploying with Cloudflare Pages
|
@targos I don't know why this test is failing now. The issue is there: nmrium/test-e2e/panels/peaks.test.ts Lines 74 to 82 in 5802722
|
It's not obvious, the error is:
|
I personally can reproduce the same errors outside of this PR (main branch), but on GitHub actions, it is specific to this PR (#2884 passed for example) |
Use a selector for the text element so the font size cannot cause issues.
Somehow today I couldn't reproduce the problem on main. Found that the issue was related to the font change. We need to ask PW to hover the text element, otherwise it can fall between the text and the annotation, which doesn't trigger the hover. |
closes: #2881