[WIP] First draft #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 13, 2020 09:42
* open zip, find the relevant xml * parse the xml * extract some of the metadata and the pattern still need to see how general all this is (how many patterns can be in one file ...)
lpatiny
requested changes
Mar 27, 2020
| const data = readFileSync(join(__dirname, '../../data/test.brml')); | ||
|
|
||
| it('check the output dictionary', async () => { | ||
| let result = await readBRML(data); |
There was a problem hiding this comment.
Please also check some values. At worse you can use https://jestjs.io/docs/en/snapshot-testing
There was a problem hiding this comment.
Tests on values added in da0378d.
There was a problem hiding this comment.
Will also move them to the refactored version (https://github.com/kjappelbaum/xrd/tree/spectrum_class).
src/reader/reader.js
Outdated
| * @param {} options={} | ||
| */ | ||
| // eslint-disable-next-line no-unused-vars | ||
| export function readBRML(binary, options = {}) { |
There was a problem hiding this comment.
Please use rather async / await syntax. We find the code easier to read. It looks like sync code while still being async.
There was a problem hiding this comment.
Hopefully a bit clearer in da0378d.
|
Thanks for the review and the time, I hope I fixed the issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft, I will still need to work on parsing some more metadata (like the specs of the instrument).
Sorry for the delay, just got my MacBook back from repair last week.