Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the numeric truncation problem of SumAs function #112

Merged
merged 1 commit into from
Jan 11, 2023
Merged

fix the numeric truncation problem of SumAs function #112

merged 1 commit into from
Jan 11, 2023

Conversation

wjiec
Copy link
Contributor

@wjiec wjiec commented Jan 6, 2023

R(v) causes precision loss when a float array is passed and needs to return an integer.

for example: SumAs[int64]([]float64{0.1, 0.2, 0.3, 0.4})

@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3852001786

  • 19 of 19 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 3099463024: 0.0%
Covered Lines: 1779
Relevant Lines: 1779
💛 - Coveralls

@chen3feng chen3feng merged commit f001ee3 into chen3feng:master Jan 11, 2023
@chen3feng
Copy link
Owner

Many thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chen3feng chen3feng chen3feng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wjiec @coveralls @chen3feng