This repository has been archived by the owner on Sep 23, 2023. It is now read-only.
Script execution bug fix #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added documentation to show this `__durian__()` uses and destroys global variable(s)
cheng-alvin
added
bug
The encoder encodes the angle brackets (`>` and `<`) to special reserver Unicode characters of `>l;` and `<` for `>` and `<` respectively.
This reverts commit 8d74a4f.
This reverts commit 545eca1.
Fixed encoder, The old encoder would just be too late since it's delayed by the `main()` function.
Allows tests to pass, no need to remove, still being tested
Hopefully this fixed the failing test case!
|
Ok, finally, a potential solution that's giving me a lot of hope is now completed in commit number 1ae2942. I've just got the shadow-dom to "copy and paste" the script elements in order for it to execute. YES! |
Signed-off-by: ✨ Alvin Cheng ✨ <eventide1029@gmail.com>
cheng-alvin
commented
Sep 8, 2023
Closed
Fixed: *Probably useless, can delete *Since scriptElements are just used once, I can probably just conbine it with line 11 As outlined in #20
…lvin/durian.js into script-execution-bug-fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the development branch for the issue where I've addressed a couple of issues with the js execution (#18) Please see #18 for more information about the issues. All development of this fix will be documented here.
Thank you!