This repository has been archived by the owner on Sep 23, 2023. It is now read-only.
Fixing problems with DOM exposure functions #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheng-alvin
added
bug
Fixed test case issue for eslint by allowing variable to be changed (Very stupid)
|
Just note that the test is not passing on commit number 57cacde because this is still In development and some code would be commented out for testing purposes |
Added `serve` script to make it easier to serve the test enviroment on the local machine's "8080" port
|
We can simply check if the component is called inside another element/component and call the script tags accordingly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to the development branch for fixing the problems and bugs that were addressed in #23. Please see #23's issue description for more information on how the issue is found and reproduced. Anyways, as usual, this Pull request is just normally used for logging the development progress of the feature.
Thank you