Improve accessibility and add ability to play segments, added component tests #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks heaps! v1.1.0 is just released with your PR :) |
|
Thanks for the quick turnaround! |
rbideau
pushed a commit
to rbideau/react-lottie
that referenced
this pull request
Nov 6, 2019
Improve accessibility and add ability to play segments, added component tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello from Eventbrite! We forked your library and made some changes to improve accessibility, play segments, added one more example showing off the segment play, and added a lot of tests for the react component itself. We also deleted the existing tests for the button since it wasn't passing and did not test the actual component. We thought that you might want to incorporate some of these changes into the
masterbranch.