rcbridge: Set cache dir via XDG_CACHE_HOME #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to how golang calls each packages' init() functions, it's impossible to have a shared library function that runs before any of the init()s. Instead, we'll set the XDG_CACHE_HOME environment variable. This has its own problems because calling setenv() from the Kotlin side only affects libc's global environ variable, which golang does not use (it maintains its own copy of envp). This commit works around that by importing a new envhack package that explicitly copies libc's environ to golang via CGO. Fixes: #11 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
added a commit
that referenced
this pull request
Jun 19, 2023
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to how golang calls each packages'
init()functions, it's impossible to have a shared library function that runs before any of theinit()s. Instead, we'll set theXDG_CACHE_HOMEenvironment variable. This has its own problems because callingsetenv()from the Kotlin side only affects libc's globalenvironvariable, which golang does not use (it maintains its own copy ofenvp). This commit works around that by importing a newenvhackpackage that explicitly copies libc'senvironto golang via CGO.Fixes: #11