Move rcbridge initialization to RcloneProvider #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RSAF was previously initializing rcbridge in MainApplication.onCreate(). Since all ContentProviders are initialized before the Application, it's possible to start receiving ContentProvider requests before rcbridge is initialized. This seems to trigger a deadlock in rclone and causes Android to kill RSAF due to the main thread hanging. When hitting this issue, crash.log would not be written because the killing is done via SIGQUIT, not via a JVM exception. This commit fixes the issue by initializing rcbridge in RcloneProvider.onCreate(). Fixes: #22 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
added a commit
that referenced
this pull request
Jul 1, 2023
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSAF was previously initializing rcbridge in
MainApplication.onCreate(). Since allContentProviders are initialized before theApplication, it's possible to start receivingContentProviderrequests before rcbridge is initialized. This seems to trigger a deadlock in rclone and causes Android to kill RSAF due to the main thread hanging. When hitting this issue,crash.logwould not be written because the killing is done viaSIGQUIT, not via a JVM exception. This commit fixes the issue by initializing rcbridge inRcloneProvider.onCreate().Fixes: #22