Block all external app access when remote is hidden #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when using the `Hide from DocumentsUI` option, external apps that were previously granted access to a file or directory retain access. This was never the intention. Now, when a remote is hidden, all further file operations via SAF will fail with a SecurityException. However, the SAF URIs are not revoked so when the remote is unhidden again, apps will immediately regain their prior access. The UI option has been renamed to `Block external app access` to clarify what will actually happen. Issue: #27 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
added a commit
that referenced
this pull request
Sep 11, 2023
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when using the
Hide from DocumentsUIoption, external apps that were previously granted access to a file or directory retain access. This was never the intention.Now, when a remote is hidden, all further file operations via SAF will fail with a SecurityException. However, the SAF URIs are not revoked so when the remote is unhidden again, apps will immediately regain their prior access. The UI option has been renamed to
Block external app accessto clarify what will actually happen.Issue: #27