-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass the total ion density to BeamCXPEC in BeamCXLine and add donor_metastable attribute to BeamCXPEC #444
Conversation
…e receiver ion density with the total ion density in BeamCXPEC (cherab#441).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vsnever,
thanks for a quick fix. I had only one comment I would like you to consider. The second one is only a minor picky suggestion.
As always, great job!
…to several lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation. This is good to be merged
This PR fixes #441 and #411.
core
and theopenadas
BeamCXPEC
classes are updated to reflect that the total ion density rather than the receiver ion density is needed to evaluate the effective CX emission coefficient.BeamCXLine
now passes the total ion density to theBeamCXPEC.evaluate()
method instead of the receiver ion density.donor_metastable
attribute is added to thecore
BeamCXPEC
class.I've added a warning to the changelog that this fix affects user results. The affected figures in the documentation have also been replaced.
Please note that tests for Python 3.9 and 3.10 will fail due to #442.