Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Support AF_UNIX in server.HTTPServer.bind_addr #80
This hotfix breaks AF_UNIX binding by leaving only the first two characters of the socket path in bind_addr (as getsockname returns the socket file path in AF_UNIX). I caught this as my code then goes on to chmod bind_addr expecting it to be a correct path after binding.
This is imo a more urgent fix than the TODO of refactoring out the hack as the hack renders valid usecases broken in 6.1.0 without monkeypatching or equivalent.
Thanks for pointing this out! It might need a regression test to prevent it from breaking during further refactoring.
@@ Coverage Diff @@ ## master #80 +/- ## ========================================== + Coverage 65.5% 66.26% +0.76% ========================================== Files 15 16 +1 Lines 2780 2855 +75 ========================================== + Hits 1821 1892 +71 - Misses 959 963 +4
Apr 7, 2018
4 of 7 checks passed
added a commit
this pull request
Apr 7, 2018
Thank you @wrmsr!
This code should reach PYPI as soon as this build is complete: https://travis-ci.org/cherrypy/cheroot/builds/363434136
It should become available at https://pypi.org/project/Cheroot/6.1.1/ in about 30 min from now.
Looks like this PR broke Windows build: https://ci.appveyor.com/project/CherryPy/cheroot/build/291