Removed viper as a required dependency. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynotLeft
reviewed
Jun 21, 2017
config.go
Outdated
|
|
||
| type DeliveryMode int | ||
|
|
||
| // List of available values for producer option `delivery_mode`. |
There was a problem hiding this comment.
List of available values for delivery_mode producer option.
ynotLeft
reviewed
Jun 21, 2017
config.go
Outdated
|
|
||
| // By default yaml reader unmarshal keys in lowercase | ||
| // but AMQP client looks for keys in camelcase | ||
| // so we're going to fix this issue. |
There was a problem hiding this comment.
By default yaml reader unmarshals keys in lowercase, but AMQP client looks for keys in camelcase, so we're going to fix this issue.
ynotLeft
reviewed
Jun 21, 2017
global.go
Outdated
| @@ -1,11 +1,9 @@ | |||
| // Just for that guys who love to keep all in the global scope. | |||
There was a problem hiding this comment.
Just for that guys who love to keep everything in the global scope.
ynotLeft
reviewed
Jun 21, 2017
mq.go
Outdated
| } | ||
|
|
||
| // You can check for errors by reading errors from this channel. | ||
| // Error provides an ability to access errors occurred. |
There was a problem hiding this comment.
Error provides an ability to access occurring errors. -> возникающие ошибки
Error provides an ability to access errors that occurred -> возникшие ошибки,
можно выбрать, что больше подходит.
ynotLeft
approved these changes
Jun 21, 2017
|
@ynotLeft u're my hero! Thank you! 💪 |
cheshir
force-pushed
the
make_viper_optional
branch
from
373562a
to
ec6b4d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.