Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module path, amqp091 dependency #55

Merged
merged 1 commit into from Feb 13, 2023
Merged

Update module path, amqp091 dependency #55

merged 1 commit into from Feb 13, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 7, 2023

This allows go get to pull version 2 of the module. Currently, attempting to upgrade to v2 of the module produces the following output:

go get github.com/cheshir/go-mq/v2
go: module github.com/cheshir/go-mq@upgrade found (v1.2.0), but does not contain package github.com/cheshir/go-mq/v2

Calling go get without /v2 installs v1.2.0.

On my fork (master branch) I created a tagged version v2.0.1 with the same changes (but updated module path), and was able to run go get -v github.com/calloway-jacob/go-mq/v2.

If this PR is accepted, I think it will also need a tag.

@cheshir cheshir merged commit 39f49a1 into cheshir:master Feb 13, 2023
@cheshir
Copy link
Owner

cheshir commented Feb 13, 2023

@calloway-jacob thank you!
It's very important PR, really appreciate your help.

@ghost ghost deleted the v2 branch February 14, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants