-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cabal 1.20 breaks Setup.hs #46
Comments
since cabal 1.20 works on ghc 7.6.3, i agree with you |
Unfortunately I've determined that copy hooks still run, so we can work around this for now by moving the install hook code to a copy hook. I don't have time to do that tonight, though. |
An additional wrinkle here is that you can't require I don't know yet what to do here. Thinking about it. The options are:
|
At this point I'm leaning towards rewriting to avoid |
Why not NOT support cabal 1.20 for now? Almost everyone will have the older
|
Because I was wrong in my first comment: cabal does not allow you to put an upper bound on the supported cabal version. And cabal nags you to upgrade it if there's a newer version available, so over time increasingly many users will have the new version. I just pushed a library to Hackage yesterday ( |
(I noticed some of these issues partially because of my difficulties in getting Hackage to accept my upload of |
@sethfowler even if people do install the newer version, we'll still be able to use the old one. ghc 7.8.2 has Cabal 1.18.1.3 built in. Unless someone does a custom build, they should have non Cabal 1.20 libs. |
@chetant It doesn't seem to work that way, unfortunately. As I mentioned, it's illegal to specify an upper version bound on cabal. As far as I can tell, if you're using a version of cabal-install built against cabal 1.20 then when you run |
OK, I've refactored Setup.hs in a way that should work on both older and newer cabal. I also switched from using
The refactored version is on the |
To clarify the above, I mean that |
Alright, so I finally got a chance to test this branch on Linux and it doesn't work, sadly. Linux's However, strangely enough, Linux's This should be straightforward to support, but it's a bit aggravating that we can't just use one solution on the two platforms. (Actually, for my other project I was able to support both platforms using |
So I went ahead and implemented the |
createArLibArchive
takes different arguments withcabal
1.20.We could potentially fix this with an upper bound on the
cabal
version, but given thatcabal
1.20 works on GHC 7.6.3 I'm inclined to updateSetup.hs
to work with the new version and bump ourcabal
lower bound.I'll go ahead and do that, but I'll leave this open for a bit in case others want to chime in.
The text was updated successfully, but these errors were encountered: