install hook (Custom setup) is not called on Setup copy/register

[anton-dessiatov]

Summary by @ezyang. Install hooks are called when ./Setup install is invoked, but this command was misguided because it's just a combination of copy and register. Some design discussion is at dda6ffe#commitcomment-6290689

---

After upgrading to cabal 1.20 my custom builds no longer work because of an instHook not being called. I've created a repository that has "die" function in its instHook and still invoking "cabal install" on it doesn't result in an error message.

You may see an example of what I'm talking about in my https://github.com/anton-dessiatov/dummy_cabal repository. I'm expecting that invoking "cabal install" on that dummy project writes "MY INSTALL HOOK!" and fails, but it doesn't print anything and finishes successfully.

[sethfowler]

Ack, sorry I didn't see this. I searched the issues for "hooks" instead of "hook" which presumably would've worked. I'll close my issue.

[anton-dessiatov]

Changed the title of this issue to simplify future searches

[tibbe]

It would greatly help if one of you could use git log and/or git bisect to figure out when it broke.

[anton-dessiatov]

Done! Revision that introduces the bug is this: dda6ffe

[sethfowler]

I just realized that cabal 1.18 doesn't seem to run copyHook, which I switched to as a workaround because instHook stopped working. So it seems that you need to run the same code in copyHook and instHook (and make that code idempotent, just in case) if you want to cover all current cabal versions.

[23Skidoo]

For current status of this, see @dcoutts's comments under dda6ffe.