-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fluent function to Tera, link to data context #21
Conversation
CI failures were because it was not being tested with features enabled, but it should be tested both with and without. I added the flag for |
I expanded the test matrix to run the cargo test and check functions both with and without feature flags. I made the clippy one run just with all features because I don't think that will ever turn up more useful results with less features enabled. I also fixed an issue with the code when the feature is not enabled. |
Any chance on some feedback on this @chevdor? I'm already using a custom build for some work that needs it, but keeping that up to date is a bit obnoxious, especially considering now I have to bump all the systems that got upgraded to the now-newer release version. If you don't plan on accepting this at least let me know so I can fork and move on. If you are still interested let me know what it needs to get merged and in a release. |
@alerque sorry for the time it took. Your update just landed when I took some time off and it then slipped out of my lists :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-fail
=> fail-fast
should work better :)
So sorry about the CI issues. I was wondering how I missed that, but the main reason is that it seems to be disabled on PRs except when they are first opened, and the CI changes were not added until later. You might consider dropping the |
This is due to the fact that I need to approve the runs so they don't run immediately but they do. |
Closes #20.
I'm not super happy with the ergonomics here. Part of the problem turned out to be the
fluent-template
crates resource loader wasn't quite as robust as hoped. Second there doesn't seem to be an easy way to make it cooperate with locales that don't have resource directories. We can fallback to a single FTL resource, but a directory still has to exist for any locales one attempts to use. Hence I didn't even include a way to pass a single file yet. I have an upstream issue open about that and am hoping to come up with a way to make this usable with just passing a single FTL file like one might pass a specific context file.I don't think this will break any current usage at all.