Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add three-wchar word, returns 0 but the three-wchar word is not added #106

Closed
YWJamesLin opened this issue Mar 21, 2016 · 6 comments
Closed

Comments

@YWJamesLin
Copy link

When I run add feature, and add

爽炸天(ㄕㄨㄤˇ ㄓㄚˋ ㄊ一ㄢ )

the program returns 0 but the phrase is not added.
screenshot_20160321_131030

screenshot_20160321_131303

screenshot_20160321_131337

@david50407
Copy link
Member

When chewing_userphrase_add returns NULL (0), it usually means add failed.

@YWJamesLin
Copy link
Author

Ok, I understand. But this phrase should not failed to be added.
And this is another example:

哈啦秀(ㄏㄚ ㄌㄚ ㄒ一ㄡˋ)

which failed to be added, too.

@david50407
Copy link
Member

Try using (bopomofo) instead of (Chinese word)

@YWJamesLin
Copy link
Author

By doing replacement, this fixed my issue, 2 example are tested.

@david50407
Copy link
Member

Maybe we have to auto-convert (phone) to (Bopomofo) or give a warning while users type non-bopomofo words or any other poka-yoke solutions.

@robert501128
Copy link
Contributor

Hi, I adopt the recommendation of @david50407 and add a function to automatically change 一(phone) to ㄧ(Bopomofo) , please check it out!
https://github.com/robert501128/chewing-editor/blob/master/src/model/UserphraseModel.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants