Add an idiom #201
Merged
Add an idiom #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The git commit message and content are inconsistent with each other. |
| @@ -92343,6 +92343,7 @@ | |||
| 狗尾續貂 0 ㄍㄡˇ ㄨㄟˇ ㄒㄩˋ ㄉㄧㄠ | |||
| 狗屁 26 ㄍㄡˇ ㄆㄧˋ | |||
| 狗屁不通 5 ㄍㄡˇ ㄆㄧˋ ㄅㄨˋ ㄊㄨㄥ | |||
| 狗屁倒灶 10 ㄍㄡˇ ㄆㄧˋ ㄉㄠˇ ㄗㄠˋ | |||
There was a problem hiding this comment.
I thought this is what I've done and record in the commit message, did I miss or misunderstand anything here?
There was a problem hiding this comment.
The subject uses ㄆㄧˊ while the body takes ㄆㄧˋ, that is inconsistent. Please use git commit --amend to rework.
There was a problem hiding this comment.
My bad ... sorry
PeterDaveHello
force-pushed
the
add-an-idiom
branch
from
cf48489
to
2ca50d7
Compare
|
@jserv I'm not sure how should I change the commit message, would you please give me your advice about that? Thanks! |
PeterDaveHello
force-pushed
the
add-an-idiom
branch
from
2ca50d7
to
be1f666
Compare
|
Updated, sorry for my careless behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.