Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(dictionary): disable wal autocheckpoint #377

Merged
merged 3 commits into from
Jan 2, 2024
Merged

refactor(dictionary): disable wal autocheckpoint #377

merged 3 commits into from
Jan 2, 2024

Conversation

kanru
Copy link
Member

@kanru kanru commented Feb 3, 2023

Closes #373

@kanru kanru marked this pull request as draft February 3, 2023 13:36
@kanru kanru added refactoring rewrite in rust Might be fixed by the rust rewrite labels Feb 4, 2023
@kanru kanru force-pushed the rust/sqlite-no-autocheckpoint branch from 3404c00 to 02688cf Compare January 2, 2024 06:04
@codecov Codecov
Copy link

codecov bot commented Jan 2, 2024 •
edited
Loading

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (42c252c) 79.94% compared to head (bb05466) 79.94%.

Files Patch % Lines
src/dictionary/mod.rs 61.11% 7 Missing ⚠️
src/dictionary/sqlite.rs 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #377   +/-   ##
=======================================
  Coverage   79.94%   79.94%           
=======================================
  Files          55       55           
  Lines       10500    10535   +35     
=======================================
+ Hits         8394     8422   +28     
- Misses       2106     2113    +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanru kanru force-pushed the rust/sqlite-no-autocheckpoint branch from fc76582 to bb05466 Compare January 2, 2024 13:52
@kanru kanru marked this pull request as ready for review January 2, 2024 13:55
@kanru kanru added this pull request to the merge queue Jan 2, 2024
Merged via the queue into master with commit d445946 Jan 2, 2024
12 checks passed
@kanru kanru deleted the rust/sqlite-no-autocheckpoint branch January 2, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring rewrite in rust Might be fixed by the rust rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(dictionary): disable sqlite auto checkpointing
1 participant
@kanru