Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dict): implement uhash loader and migrator #434

Merged
merged 11 commits into from
Mar 7, 2024
Merged

Conversation

kanru
Copy link
Member

@kanru kanru commented Jan 28, 2024

No description provided.

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 84.38%. Comparing base (acd5bff) to head (c94ba0e).

Files Patch % Lines
src/dictionary/cdb.rs 0.00% 12 Missing ⚠️
src/dictionary/kv.rs 0.00% 7 Missing ⚠️
src/dictionary/uhash.rs 97.84% 3 Missing ⚠️
src/dictionary/loader.rs 97.05% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   79.69%   84.38%   +4.69%     
==========================================
  Files          61       62       +1     
  Lines       11466    12976    +1510     
==========================================
+ Hits         9138    10950    +1812     
+ Misses       2328     2026     -302     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanru kanru added this to the v0.7.0 milestone Jan 28, 2024
@kanru kanru added the rewrite in rust Might be fixed by the rust rewrite label Jan 28, 2024
@kanru kanru linked an issue Jan 28, 2024 that may be closed by this pull request
@kanru kanru marked this pull request as ready for review March 7, 2024 14:29
@kanru kanru added this pull request to the merge queue Mar 7, 2024
@kanru kanru removed this pull request from the merge queue due to a manual request Mar 7, 2024
@kanru kanru added this pull request to the merge queue Mar 7, 2024
Merged via the queue into master with commit 76c9ecb Mar 7, 2024
19 checks passed
@kanru kanru deleted the rust/hash-dict branch March 7, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rewrite in rust Might be fixed by the rust rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(dictionary): support migration from hash.dat to newer db files
1 participant