Added bootstrap and centering #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will it work offline? |
|
It only work offline if you included the bootstrap files in the repo.
On Fri, Apr 6, 2018 at 6:19 PM chexbox ***@***.***> wrote:
Will it work offline?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQX6GwLrAvoso8cSAMCEGC_5uIKnn0fYks5tl_f6gaJpZM4TKndJ>
.
--
Sincerely,
Henry Gruett
|
|
Do we need to use Bootstrap to center it? Often that can be achieved with CSS alone. |
|
Should we close this? It looks like it was achieved with CSS. |
|
I included bootstrap because it will save your lives later with all the
layout-ing you will need to do for buttons and an output screen. Up to you
if you think you want that. I would though if I were you.
…On Mon, Apr 9, 2018 at 4:31 PM, infinitytec ***@***.***> wrote:
Should we close this? It looks like it was achieved with CSS.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQX6Gzva3-akW8BmIQWlPbKMYnZr0K7Hks5tm9MwgaJpZM4TKndJ>
.
|
|
As it doesn't look like we are doing this, I am closing this PR. I will create an issue so that we remember this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the calculator centered using bootstrap