Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a helper method for Welsh Language #57

Merged
merged 5 commits into from
Oct 15, 2019
Merged

feat: add a helper method for Welsh Language #57

merged 5 commits into from
Oct 15, 2019

Conversation

araknoid
Copy link
Contributor

@araknoid araknoid commented Oct 6, 2019

Issue 37: Add a helper method for Welsh Language

fix #37

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Issue 37: Add a helper method for Welsh Language

#37
@codecov-io
Copy link

codecov-io commented Oct 6, 2019

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #57   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          50     51    +1     
  Branches        3      3           
=====================================
+ Hits           50     51    +1
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e26cb7e...37e1bd0. Read the comment docs.

@araknoid
Copy link
Contributor Author

araknoid commented Oct 9, 2019

@chgasparoto conflicts resolved.

@chgasparoto chgasparoto merged commit 54a97b9 into chgasparoto:master Oct 15, 2019
@chgasparoto
Copy link
Owner

🎉 This PR is included in version 1.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a helper method for Welsh Language
3 participants