Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#165865116 Fix failing coverage reporter #26

Merged
merged 1 commit into from
May 7, 2019

Conversation

chidimo
Copy link
Owner

@chidimo chidimo commented May 7, 2019

What does this PR do?

Fix failing coverage report to coveralls

Description of Task to be completed?

Replace mocha-lcov-reporter with nyc
Add coveralls repo token to .coverage.yml, then ignore. This sends the
coverage report from my local machine.
Run coverage reporting after_success

How should this be manually tested?

  1. Clone the repo
  2. cd into the root folder on a cmd shell and issue command yarn install.
  3. Execute command yarn test

Any background context you want to provide?

Nil

What are the relevant pivotal tracker stories?

165865116

Screenshots (if appropriate)

Nil

Questions:

Nil

Replace mocha-lcov-reporter with nyc
Add coveralls repo token to .coverage.yml, then ignore. This sends the
coverage report from my local machine.
Run coverage reporting after_success

[Finishes #165865116]
@chidimo chidimo merged commit d6f1038 into develop May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant