-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#166075487 Connect loan model to postgres database #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On pages with the profile icon, the hidden submenu creates an extra space to the right of the screen. This commit corrects this by changing the submenu width for smaller devices [Finishes #166104469]
- pass the where statement from the query caller. This ensures that the where statement can be constructed in any manner we wish for cases where there may be AND - This pattern also allows passing LIMIT if we like to
…dimo/Quick-Credit into ch-connect-loan-db-166075487
- Create method for insert with return id - Create method for in-situ incrementation of a value
- Create helper function to hold repetitive tasks - check if loan exists - add loan to database and return the id - update loan status - update loan balance - get loan by given id - get loan repayment history - add repayment to database and return the id - get repayment by id Add adminid field to repayment to capture the admin to collect the loan Refactor controller to perform read and write operations on backend db
- Create helper functions for modularity - function check user existence - function to add user to db - function to get user by id or email
- use psql to load data before test - use psql to clear database after test - each test file loads and clears data each time it runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Connect loan model to postgres database
Description of Task to be completed?
/models/Model.js
to sendSQL
queries usingpg
.async/await
to gather the results of such queries and return it./controllers/helpers/LoansController
to handle repetitive tasks.psql
with node'sexec
to populate and clear out the test database tablesHow should this be manually tested?
cd
into the root folder on acmd
shell and runyarn install
. PowerShell is fine also..env
file in the root of the project and supply values for the following parameterstestdb
.yarn test
yarn test
Any background context you want to provide?
Be sure to setup the database as instructed above
What are the relevant pivotal tracker stories?
166075487
Screenshots (if appropriate)
Nil
Questions:
Nil