Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send email notifications #43

Merged
merged 3 commits into from
May 22, 2019
Merged

Send email notifications #43

merged 3 commits into from
May 22, 2019

Conversation

chidimo
Copy link
Owner

@chidimo chidimo commented May 22, 2019

What does this PR do?

Send out email notifications

Description of Task to be completed?

  1. Send email notifications on signup, loan application, and rejection or approval of a loan
  2. Improve test coverage and maintainability

How should this be manually tested?

  1. Clone the repo
  2. cd into the root folder on a cmd shell and run yarn install. PowerShell is fine also.
  3. Setup a PostgreSQL DB.
  4. Define a .env file in the root of the project and supply values for the following parameters
    JWT_SECRET=<json-web-token-secret>
    DBNAME=<database-name>
    PGPASSWORD=<postgres-db-password>
    PGHOST=<postgres-db-host>
    PGUSER=<postgres-db-user>
    PGPORT=<postgres-db-port>
  5. Create a PostgreSQL database called testdb.
  6. Run command yarn test

Any background context you want to provide?

What are the relevant pivotal tracker stories?

165839924
166182329
166135690

Screenshots (if appropriate)

Nil

Questions:

Nil

- send email notification on sign up
- send email notification upon applying for a loan
- send email notification upon approval or rejection of a loan
- use sendgrid API to send emails

[Delivers #165839924, #166182329, #166135690]
- nyc fails to cover async await function, to correct this
- install babel-plugin-istanbul
- add it as a test environment requirement in .babelrc
-
@chidimo chidimo merged commit 532f177 into develop May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant