Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f-strings not supported in python 3.5 #30

Closed
scottgigante opened this issue Sep 17, 2020 · 4 comments · Fixed by #31
Closed

f-strings not supported in python 3.5 #30

scottgigante opened this issue Sep 17, 2020 · 4 comments · Fixed by #31

Comments

@scottgigante
Copy link

By including f-strings in the latest release (https://github.com/Chilipp/autodocsumm/blob/master/autodocsumm/__init__.py#L530), autodocsumm is no longer compatible with python 3.5, despite the badge in the README saying it is. I suggest you either remove 3.5 from the badge and add a python_requires=">=3.6" to setup.py, or use str.format instead.

scottgigante added a commit to KrishnaswamyLab/scprep that referenced this issue Sep 17, 2020
Chilipp added a commit that referenced this issue Sep 22, 2020
as they are not available for python 3.5, see
#30
@Chilipp
Copy link
Owner

Chilipp commented Sep 22, 2020

thanks for reporting this @scottgigante! I made the necessary chances in #31 and merge it when the CI passes

@scottgigante
Copy link
Author

Thanks @Chilipp !

@Chilipp
Copy link
Owner

Chilipp commented Sep 24, 2020

FYI @scottgigante, the new release solving this issue is now available via pip and conda-forge

@scottgigante
Copy link
Author

scottgigante commented Sep 24, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants