Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added getacqinfo / getfileinfo functions for HFB acquisitions. #9

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

james-s-willis
Copy link
Contributor

No description provided.

@james-s-willis
Copy link
Contributor Author

@ketiltrout is there a way to test this before merging?

Copy link
Member

@ketiltrout ketiltrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be confusion here over whether HFB files are corr files or something new.

You're adding entries to CorrAcqInfo here but over in chime-experiment/chimedb_di#14 you've defined new HFB-specific tables.

So, definitely step one is to figure out whether HFB files are corr files or not.

If they're not, you'll also need to define them in the acq_format file before this PR can be approved. The TeX for that is over here and the document provides instructions on the procedure for updating itself: https://github.com/chime-experiment/ch_memos/blob/master/acq_format/acq_format.tex

The PDF version of the acq format document is in doclib: https://bao.chimenet.ca/doc/documents/5

alpenhorn/auto_import.py Outdated Show resolved Hide resolved
alpenhorn/auto_import.py Outdated Show resolved Hide resolved
alpenhorn/auto_import.py Outdated Show resolved Hide resolved
alpenhorn/auto_import.py Show resolved Hide resolved
alpenhorn/auto_import.py Show resolved Hide resolved
alpenhorn/auto_import.py Outdated Show resolved Hide resolved
@jrs65
Copy link
Contributor

jrs65 commented Feb 24, 2021

@james-s-willis as Don says you'll also need to create a new hfb acq type for this. The corr acq type is to hold visibility correlation (which these are not).

@james-s-willis
Copy link
Contributor Author

james-s-willis commented Feb 26, 2021

if not file.corrinfos.count():

I know I'm not editing this part, but shouldn't this line have file.hkinfos.count() instead of corrinfos? @ketiltrout

@james-s-willis
Copy link
Contributor Author

@ketiltrout, @jrs65 I have updated this PR with your corrections and I have created a new PR (https://github.com/chime-experiment/ch_memos/pull/4) for the HFB acq type in the CHIME Archive Data Format document.

@ketiltrout
Copy link
Member

I know I'm not editing this part, but shouldn't this line have file.hkinfos.count() instead of corrinfos? @ketiltrout

More amazingness from this code. You're right, and I made an issue for it, but really it looks like that if should be deleted and the except line above should be fixed so it only catches the exception thrown if the update fails, not everything.

@james-s-willis james-s-willis merged commit 2a3abf5 into master Mar 10, 2021
@james-s-willis james-s-willis deleted the jsw/hfb_support branch March 10, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants