-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: async pathRewrite #397
Conversation
DeepCode's analysis on #478d9b found:
💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues. |
Nice. Looks good. The following needs to be in place before this PR can be accepted:
You can have a look at: Unit tests for path rewriter: Types test: |
Alright, I'll take a look at solving these requirements. Thanks |
I think this is ready to have another look. One change I made by accident affected the |
Yes, please undo the changes to I'll checkout the PR to do some additional testing. |
Thanks! Published a new beta version You can install it with: Let me know if everything still works. I'll publish a final shortly after confirmation. |
Thanks, I'll try out this version and let you know if anything goes wrong. |
The "http-proxy-middleware@0.21.0-beta.3" seems to work as expected in what I'm working on. |
published final version: |
Related issue: #374