(v5) fix top header buttons misaligned #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stylesheets that were linked in the index.html were redundant, as they were already bundled by the webpack. The style.css was again imported in the components/app.jsx. Now, it is placed in the index.js in a order that style.css overrides the other stylesheets.
arnabsen1729
changed the title
|
Very nice description put in the PR @arnabsen1729! That's the way! 👏🏼 🔥 |
chinchang
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #498
Ideally, we would want the bundler to bundle the CSS files, and hence we should include the stylesheets in the
index.js. So we can remove the linked CSS files in theindex.html.The main issue regarding the misalignment was that
style.csswas being overridden byhint.min.css. There was one import of thestyle.cssinsrc/components/app.jsxwhich was the culprit. So removed it from there and put it together with the other imports in theindex.js. Also maintained the order such thatstyle.cssis not overridden anymore. This fixes the alignment issue.Before
After
