Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth controller e2e tests #102

Merged
merged 7 commits into from
Feb 18, 2024
Merged

Auth controller e2e tests #102

merged 7 commits into from
Feb 18, 2024

Conversation

cherylli
Copy link
Collaborator

@cherylli cherylli commented Feb 17, 2024

Description

Add e2e tests for auth controllers. There are also a few adjustments like

  • not actually sending email when doing tests
  • making password min 8 chars
  • added logger for auth service instead of console.log
  • added a few undocumented api responses

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Tests

How Has This Been Tested?

yarn test:e2e auth

image

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

Copy link
Contributor

@JoshuaHinman JoshuaHinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed

Copy link
Collaborator

@curtwl curtwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cherylli cherylli merged commit 16638e7 into dev Feb 18, 2024
1 check passed
@cherylli cherylli deleted the feature/auth-tests branch February 18, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants