Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug "Auth - cannot read roles on server startup" #134

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Fix bug "Auth - cannot read roles on server startup" #134

merged 4 commits into from
Apr 17, 2024

Conversation

curtwl
Copy link
Collaborator

@curtwl curtwl commented Apr 15, 2024

Description

Added optional chaining in two places

Issue link

Fixes Auth - cannot read roles on server startup

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

Copy link
Collaborator

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. I did some testing if they have an access token in the browser, they would continue to be authorized, but once that's gone, they would become unauthorized (have to /login again)
So it seems reasonable as we can't revoke access_token

Copy link
Collaborator

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!! All tests passed! I also tested an endpoint that need an admin to logged in and it worked!

@curtwl curtwl merged commit 6442851 into dev Apr 17, 2024
1 check passed
@curtwl curtwl deleted the fix/roles branch April 17, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants