Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 30min timeout to github actions test workflow #143

Merged
merged 2 commits into from
May 4, 2024
Merged

Add 30min timeout to github actions test workflow #143

merged 2 commits into from
May 4, 2024

Conversation

cherylli
Copy link
Collaborator

@cherylli cherylli commented May 2, 2024

Description

Adding timeout since last failed run was 6h long which is using up github actions quota. A normal run is around 6-9mins

Issue link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested on my forked

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • x] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@cherylli cherylli self-assigned this May 2, 2024
JoshuaHinman
JoshuaHinman approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@JoshuaHinman JoshuaHinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

timDeHof
timDeHof approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great way to prevent additional cost to our quota.

@cherylli cherylli merged commit 5dfef2e into dev May 4, 2024
1 check passed
@cherylli cherylli deleted the cherylli-patch-1 branch May 4, 2024 02:22
timDeHof added a commit that referenced this pull request May 9, 2024
@timDeHof
chore(CHANGELOG.md): update changelog with new feature and fix
40698c9 
The changelog has been updated to include the following changes:
- A new feature has been added to the deleteFeature method. It now uses a DeleteFeatureResponse and returns an object with a successful status and a message. This change was made in pull request #150.
- Various updates and additions have been made to the test github actions workflow, form title references, and form input types. These changes were made in pull requests #143, #145, and #146 respectively.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timDeHof timDeHof timDeHof approved these changes

@JoshuaHinman JoshuaHinman JoshuaHinman approved these changes

@Ajen07 Ajen07 Awaiting requested review from Ajen07

@curtwl curtwl Awaiting requested review from curtwl

Assignees

@cherylli cherylli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cherylli @timDeHof @JoshuaHinman