Feat: add voyage project submission status to /me endpoint
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity and response fix(users): update user object with sprintCheckInIds and projectStatus The migration.sql file adds a new column "projectSubmitted" to the VoyageTeam table in the database. This column is set to a default value of false. The schema.prisma file is updated to include the new "projectSubmitted" field in the VoyageTeam model. The users.select.ts file is modified to include the "projectSubmitted" field in the select query for private user details. The team.entity.ts file is updated to include the "projectSubmitted" field in the VoyageTeamEntity class. The users.response.ts file is modified to include the "projectSubmitted" field in the VoyageTeam class. The users.service.ts file is updated to fetch the "projectSubmitted" field from the database and update the user object with the sprintCheckInIds and projectStatus. These changes are done to support the functionality of tracking whether a project has been submitted by a VoyageTeam. The "projectSubmitted" field allows for easy retrieval of this information and the updated user object provides the necessary data for displaying the project status to the user.
…point The `/me` endpoint now includes the voyage project submission status. This change was made to provide users with information about the status of their voyage project submission.
cherylli
reviewed
May 24, 2024
…Team entity and response" This reverts commit 8f68cb6.
…UserDetailSelect The FormResponseVoyageProject field is added to the privateUserDetailSelect object. This change allows the private user details to include the FormResponseVoyageProject field when selecting user data.
…ser object feat(users.service.ts): update user object with sprintCheckInIds and modify voyageTeamMembers based on project submission status The code now includes a check for the existence of the user before updating the user object. This prevents any potential errors when trying to update a non-existent user. The user object is then updated with the sprintCheckInIds. Additionally, the voyageTeamMembers are modified based on the project submission status. If the team member has a voyage team with a FormResponseVoyageProject, the projectSubmitted property is set to true. Otherwise, it is set to false.
Ok, I was able to check and modify the voyageTeam with the |
cherylli
previously approved these changes
May 26, 2024
cherylli
reviewed
May 26, 2024
Ajen07
previously approved these changes
May 26, 2024
The console.log statement was removed as it was not providing any useful information and was cluttering the code.
Ajen07
approved these changes
May 28, 2024
cherylli
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Features and Fixes
feat(users): Added support for the
projectSubmittedfield in the VoyageTeam entity and response.fix(users): Updated the user object with sprintCheckInIds and projectStatus.
Summary of Changes
Database Changes:
Added a new column
projectSubmittedto theVoyageTeamtable with a default value of false.Updated
schema.prismato include the newprojectSubmittedfield in theVoyageTeammodel.Backend Modifications:
Updated
users.select.tsto include theprojectSubmittedfield in the select query for private user details.Updated
team.entity.tsto include theprojectSubmittedfield in theVoyageTeamEntityclass.Modified
users.response.tsto include theprojectSubmittedfield in theVoyageTeamclass.Updated
users.service.tsto fetch theprojectSubmittedfield from the database and update the user object with the sprintCheckInIds and projectStatus.Issue link
closes Add voyage project submission status in
/meendpointType of change
How Has This Been Tested?
Testing can be done by inspecting the response for the
/meendpoint in swagger for the field.It would be either "True" or "False".Checklist: