Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: e2e tests for features #168

Merged
merged 11 commits into from
Jun 26, 2024
Merged

Test: e2e tests for features #168

merged 11 commits into from
Jun 26, 2024

Conversation

Ajen07
Copy link
Collaborator

@Ajen07 Ajen07 commented Jun 23, 2024

Description

  • e2e test for features controller

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • tested with yarn test:docker

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@Ajen07 Ajen07 self-assigned this Jun 23, 2024
@Ajen07 Ajen07 changed the title Test/e2e tests for features Test: e2e tests for features Jun 23, 2024
cherylli
cherylli previously approved these changes Jun 23, 2024
Copy link
Collaborator

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks fine, just one minor suggestion so the error response matches the forbidden error

Also just a note all forbidden stuff will need to be moved to our CASL authorization, but shouldn't affect the tests. In fact it's good to have these tests now, so we know we don't mess up when updating it

src/features/features.controller.ts Outdated Show resolved Hide resolved
JoshuaHinman
JoshuaHinman previously approved these changes Jun 24, 2024
Copy link
Contributor

@JoshuaHinman JoshuaHinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed - looks good

@Ajen07 Ajen07 dismissed stale reviews from JoshuaHinman and cherylli via a8cec63 June 24, 2024 04:02
Copy link
Collaborator

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Collaborator

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! All tests passed and swagger works.

@Ajen07 Ajen07 merged commit a306924 into dev Jun 26, 2024
1 check passed
@Ajen07 Ajen07 deleted the test/e2e-tests-for-features branch June 26, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants