Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:grouping prisma models into separate domain files #172

Merged

Conversation

timDeHof
Copy link
Collaborator

@timDeHof timDeHof commented Jul 2, 2024

Description

The prisma dependencies was updated to the latest version to use the new feature of multiple schemas. Also the main schema file was refactored to have related models grouped into a same domain files with clear naming conventions.

Issue link

Fixes # (issue)
https://app.clickup.com/t/86b0zg2qf

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  1. run yarn
  2. run yarn seed to check if the prisma will still populate the database
  3. run yarn test:docker to check if test still pass

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

Useful links:

how-to-use-existing-prisma-cli-commands-with-multiple-prisma-schema-files

The prisma dependencies was updated to the latest version to use the new feature of multiple schemas.
…forms, solo projects, team meetings, team resources, team project ideas, team project features, team stack, and tokens

The new models have been added to the schema to support various functionalities. These include the onboarding checklist, health check, forms, solo projects, team meetings, team resources, team project ideas, team project features, team stack, and tokens. These models will enable the application to manage and track user onboarding, health check status, form submissions, solo projects, team meetings, team resources, project ideas, project features, tech stack, and tokens for password reset and email verification.
…ed by domain type

The prisma models have been refactored to be grouped by domain type. This improves the organization and maintainability of the codebase by grouping related models together.
The prisma dependency has been updated to version 5.16.1. This update may include bug fixes, performance improvements, or new features provided by the prisma library.
@timDeHof
Copy link
Collaborator Author

timDeHof commented Jul 2, 2024

I noticed that the tests have passed. But if you try to push, studio, or migrate the db, you will face with errors like this:
Screenshot 2024-07-02 at 3 45 09 PM
I don't know if it's only an issue in docker or if its occurring on local computers too. it seems that others are issues with this feature too.
prisma/prisma#24413

UPDATE:I ran yarn in docker to update the packages and now yarn studio:test:docker worked.

Copy link
Collaborator

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran all the more frequently used prisma commands and tests, all good 👍

Copy link
Contributor

@JoshuaHinman JoshuaHinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything passed without any hiccups - seed, migrate, studio all worked - looks good!

@timDeHof timDeHof merged commit b8e861d into dev Jul 6, 2024
1 check passed
@timDeHof timDeHof deleted the chore/upgrade-prisma-and-separate-schema-into-multiple-files branch July 6, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants