Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all failed tests (app, ideation) #98

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Fixed all failed tests (app, ideation) #98

merged 5 commits into from
Feb 5, 2024

Conversation

cherylli
Copy link
Collaborator

@cherylli cherylli commented Feb 2, 2024

Description

Fixed the ideations tests which broke mainly due to switching from bearer token to http cookies.

Also a few minor changes

  • added "moduleDirectories": ["<rootDir>/../", "node_modules"] to fix absolute paths not working with e2e test files
  • close app when finished to avoid openHandles
  • restrcuture seed file, so the seed() function can be called from within the code (for e2e testing)

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

yarn test:e2e
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@curtwl curtwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passing!

Copy link
Contributor

@JoshuaHinman JoshuaHinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cherylli cherylli merged commit 9e1f9a2 into dev Feb 5, 2024
1 check passed
@cherylli cherylli deleted the fix/ideation-e2e branch February 5, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants