Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of UI Layout for Login and Registration Pages #67

Merged
merged 51 commits into from
Feb 13, 2024

Conversation

timothyrusso
Copy link
Collaborator

Description

UI layout for the Login and Register page.

Important notes:

  • Missing some reusable components that must be updated, like the input text for the form and the Alert component that must accept also links in the text (and longer texts).
  • Missing the Create new password modal, i think this could be created in another task.
  • Missing the show/hide password for the input text, this must be handled with the new reusable components.
  • Missing the logic to show the Alert component (because depend from a backend response), I have just created a state that can be used to test the Alert UI on the page.

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
chingu-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2024 2:37pm

Copy link
Collaborator

@Dan-Y-Ko Dan-Y-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the create new password card. Rather just get that done here so the ui for this auth flow can be finished.

Need to add the show/hide text functionality in the password input.

Also, the ui does need some changes from design perspective because it does not look good on smaller screens currently so need to wait for that.

@timothyrusso
Copy link
Collaborator Author

Can you add the create new password card. Rather just get that done here so the ui for this auth flow can be finished.

Need to add the show/hide text functionality in the password input.

Also, the ui does need some changes from design perspective because it does not look good on smaller screens currently so need to wait for that.

@Dan-Y-Ko, I've added the new password modal along with the show/hide functionality. I'll await the UI updates. However, I believe it might be better to close this PR in the meantime, as it seems to be extending for quite a long period. What are your thoughts on this?

@Dan-Y-Ko
Copy link
Collaborator

Can you add the create new password card. Rather just get that done here so the ui for this auth flow can be finished.
Need to add the show/hide text functionality in the password input.
Also, the ui does need some changes from design perspective because it does not look good on smaller screens currently so need to wait for that.

@Dan-Y-Ko, I've added the new password modal along with the show/hide functionality. I'll await the UI updates. However, I believe it might be better to close this PR in the meantime, as it seems to be extending for quite a long period. What are your thoughts on this?

This isn't a blocker for any tasks so it's fine. The new designs are ready btw.

@timothyrusso
Copy link
Collaborator Author

Can you add the create new password card. Rather just get that done here so the ui for this auth flow can be finished.
Need to add the show/hide text functionality in the password input.
Also, the ui does need some changes from design perspective because it does not look good on smaller screens currently so need to wait for that.

@Dan-Y-Ko, I've added the new password modal along with the show/hide functionality. I'll await the UI updates. However, I believe it might be better to close this PR in the meantime, as it seems to be extending for quite a long period. What are your thoughts on this?

This isn't a blocker for any tasks so it's fine. The new designs are ready btw.

@Dan-Y-Ko Great! I'll work on the new design

@timothyrusso
Copy link
Collaborator Author

@Dan-Y-Ko I've completed the design, let me know if I've missed something or if I should change something, thanks!

Copy link
Collaborator

@Dan-Y-Ko Dan-Y-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I go to /sign-in it starts with the create new password thing. That's not how it should be

Get rid of the alert at the top. We won't be using that anymore

Copy link
Collaborator

@Dan-Y-Ko Dan-Y-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dan-Y-Ko Dan-Y-Ko merged commit 2afa824 into dev Feb 13, 2024
3 checks passed
@Dan-Y-Ko Dan-Y-Ko deleted the feature/login-page branch February 13, 2024 05:35
Dan-Y-Ko added a commit that referenced this pull request Jul 9, 2024
Implementation of UI Layout for Login and Registration Pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants