-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of UI Layout for Login and Registration Pages #67
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the create new password card. Rather just get that done here so the ui for this auth flow can be finished.
Need to add the show/hide text functionality in the password input.
Also, the ui does need some changes from design perspective because it does not look good on smaller screens currently so need to wait for that.
@Dan-Y-Ko, I've added the new password modal along with the show/hide functionality. I'll await the UI updates. However, I believe it might be better to close this PR in the meantime, as it seems to be extending for quite a long period. What are your thoughts on this? |
This isn't a blocker for any tasks so it's fine. The new designs are ready btw. |
@Dan-Y-Ko Great! I'll work on the new design |
@Dan-Y-Ko I've completed the design, let me know if I've missed something or if I should change something, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I go to /sign-in it starts with the create new password thing. That's not how it should be
Get rid of the alert at the top. We won't be using that anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Implementation of UI Layout for Login and Registration Pages
Description
UI layout for the Login and Register page.
Important notes:
Issue link
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: