-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLS ready to use component #688
Comments
Any updates on this? |
Hi @ShivamJoker, We are thinking about the ecosystem of integratabtle/composable player, But I think we got over thinking about the mechanism which prevent us from further progress. |
Dear everyone, (@ShivamJoker, @vhfmag, @sessgreem, @marcelfahle and @chintan9) I got some time to work on HLS video player, I put some efforts to make it more reusable, more handy and specifically more reliable.
Updates are scoped in the dev branch and all changes are documented and explained so would be pleasure if you could test and give us feedback. As these point we also really appreciate if you want to help in our infrastructure core. Hope to see you all, and happy Nowruz. |
Which version should we install to use it? |
Hey @Kerotobil, it is not published in npm yet yarn add "https://github.com/chintan9/plyr-react.git#release" More info on installation process, stackoverflow |
Yes i installed with yarn add "https://github.com/chintan9/plyr-react.git#release" , but video don't getting. |
Hey @Kerotobil, you nearly scared me to death 😂 It seems that you forgot to pass the HLS instance to useRef - const hls = useRef<Hls>(nuull);
+ const hls = useRef<Hls>(new Hls()); Also you can now remove those |
Which version of |
|
I made a codesandbox, but cause I need the latest version of plyr-react and codesandbox tried to load it from other registry, you will see duplication for the plyr-react itself. I'm pretty sure the problem might be in the installation phase or our packaging side. https://codesandbox.io/s/wild-field-tp14zg?file=/src/plyr-react.tsx:140-144 |
Yes, looks fine. But my webpack error persists, I'm trying to solve it. It may be due to a different plugin in the project. I'll post again when I'm done. Thanks |
Looking forward to hearing from you. |
@chintan9 Just about to think about implementing this module into our lib, but curious why it seems v5 broke support that was in v4? We're getting the same error as @Kerotobil in v5. |
There are few issues with the Custom HLS player.
|
@towfiqi , You can pass |
I'm not that player expert but being it seems that HLS player is so popular among the community,
In this way we've some known mentioned issues we will try to fix, but don't hesitate to add you add your need or special use cases.
up-vote this issue (comment) if you see it helpful for your project?
The text was updated successfully, but these errors were encountered: