Dev msft 03022023 #2
Conversation
anjpar
requested review from
varuns-nvidia,
andreslagarcavilla,
bharatpillilli,
Bryankel,
howardtr,
korran,
mcockrell-google,
pkwidzin-amd,
vsonims and
mhatrevi
|
Why not merge to main? |
There was a problem hiding this comment.
Can we please remove all the autogenerated HTML noise in the
src/integration/docs/caliptra_reg_html directory? Over time this will bloat the repository. Instead we can have a github workflow generate the HTML and publish it to GitHub Pages (I'm happy to set this up for you ASAP).
It is a long story - but in short, the issue is that we don't have open source RTL toolsets that can assertively ensure that all changes coming b/w multiple committers will work together since toolsets used to do the work are licensed from different companies. So need to do a thankless integration job/run regressions/run DC/timing checks and other tool sets before releasing to main. (Did I say short? :-) ) |
Thanks Kor - If you can enable this in the "goog-dev" branch through Howard, it will naturally trickle in the change to main & msft branches (including internal repo). I would LOVE it if the rdl changes are up to date in HTML which can be reviewed as a spec |
|
@anjpar - Did the README get missed in the PR or I missed it? |
| @@ -1,7 +1,52 @@ | |||
| _*Last Update: 2023/03/02*_ | |||
There was a problem hiding this comment.
nit: can this be a Markdown file to capture formatting? I'm ok with a TODO to update in the future. This applies to all text files.
There was a problem hiding this comment.
Ack on that - we used to have README.md - I left a comment above for @anjpar to see if it went missing that had tools etc. information
I have #3 that targets your branch and removes the register docs and adds a GitHub workflow to generate the docs. You can download the the generated "github-pages" artifact from the most recent run at https://github.com/chipsalliance/caliptra-rtl/actions/runs/4321469794. For some bizarre reason, to work with GitHub Pages in the future, this needs to be a zip file containing a tarball. I can't deploy the generated artifact to GitHub pages yet as my branch doesn't have permission (and you probably haven't enabled GitHub pages for this repo anyways). But we can make this happen automatically from the main branch if you let me help you with the GitHub settings (either temporarily make me an admin, or I can work with Matt). I would love it if you were to merge PR #3 into this PR, and when you're ready to merge this PR to dev-msft, use "Squash and Merge" from the dropdown below to merge without any HTML in the history (if you use "Merge pull request" or "Rebase and merge", the HTML will still be in the history). |
Thanks for catching it, Bharat. The README had gotten missed due to a clean-up issue in the sync script. I've manually added the README now, and also updated the script. |
Delete autogenerated register docs from repo and add workflow to generate them
Rename 0.8 doc directory to main.
|
Be sure to to use "Squash and merge" instead of "Merge pull request" or "Rebase and merge" |
|
Let's complete addressing Howard's comments please |
…oint to caliptra-rtl directory
…liptra-rtl into dev_msft_03022023
* Doc file updates, no source code/scripts yet * Remove MSFT copyright * Remove Coming_soon.txt * Delete VERSION.txt * Dev msft 03022023 (#2) * Initial Pre0p8 release * Fixed typos in release notes * Delete autogenerated register doc HTML. * Add a GitHub workflow to autogenerate the register docs. * Adding updating README.md * Rename 0.8 doc directory to main. * Updated repo name to caliptra-rtl and set WORKSPACE env variable to point to caliptra-rtl directory --------- Co-authored-by: Anjana Parthasarathy <anjpar@fe76.svceng.com> Co-authored-by: Kor Nielsen <kor@google.com> Co-authored-by: Kor Nielsen <korn@xdas.com> --------- Co-authored-by: Caleb Whitehead <cwhitehead@microsoft.com> Co-authored-by: Anjana Parthasarathy <anjpar@fe76.svceng.com> Co-authored-by: Kor Nielsen <kor@google.com> Co-authored-by: Kor Nielsen <korn@xdas.com>
updated property suite in hmac_drbg folder
This is first drop of Pre 0p8 RTL into ChipsAlliance caliptra-rtl repository. Update details can be found in the release notes.