Deprecate toBools in Bits (should be asBools)

[mwachs5]

See discussion in #2124 (comment)

Type of issue:feature request | documentation | other enhancement

Impact: API modification

Development Phase: proposal

Other information

If the current behavior is a bug, please provide the steps to reproduce the problem:

What is the current behavior?

There still exists a .toBools function, undeprecated, in Bits.scala

What is the expected behavior?

All the .toBools were deprecated and turned into asBools. This one seems to have been forgotten? Or was that intentional?

Please tell us about your environment:

What is the use case for changing the behavior?

consistent function names leading to less cognitive load on users

[sequencer]

I just notice this:

314:  final def toBools: Seq[Bool] = macro SourceInfoTransform.noArg
317:  final def toBools(dummy: Int*): Seq[Bool] = macro SourceInfoWhiteboxTransform.noArgDummy

121635e didn't deprecate toBools, but deprecated do_toBools, so I just removed do_toBools, but didn't remove toBools.

If user from 3.4 used toBools, they will receive a runtime deprecation warning, rather than a normal deprecation warning, (and this may break binary compatibility? @jackkoenig)

So currently, in the master code, toBools will introduce which will throw do_toBools not implemented, so I propose remove toBools directly in Chisel 3.5, since runtime deprecation warning has already warned users.

[debs-sifive]

@ibukenya nobody is working on this ticket yet, if you want to give it a try!

[mwachs5]

@debs-sifive , @ibukenya I think that @sequencer was working on this (and realized it was a little complicated, need to add to import Chisel._. #2170

[jackkoenig]

This was removed in v3.5.0, fixed by #2170