Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chisel plugin to mill build system. #1572

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Add chisel plugin to mill build system. #1572

merged 2 commits into from
Sep 2, 2020

Conversation

sequencer
Copy link
Member

@sequencer sequencer commented Aug 28, 2020

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • new feature/API

API Impact

None

Backend Code Generation Impact

None

Desired Merge Strategy

  • Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Release Notes

Add chisel-plugin to mill build system.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.0, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@sequencer sequencer requested a review from a team as a code owner August 28, 2020 06:30
@sequencer sequencer requested review from albertchen-sifive and removed request for a team August 28, 2020 06:30
@sequencer sequencer force-pushed the mill_chisel_plugin branch 2 times, most recently from c2a57d4 to 245bcef Compare August 28, 2020 06:51
@sequencer
Copy link
Member Author

@azidar I moved src-2.12 to src, since chisel3 is a little tricky to support which, is any reason to do so?

Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/main/scala-2.12 is SBT standard way of making sure something only compiles when using Scala 2.12, Mill probably has support for something similar.

@sequencer
Copy link
Member Author

fix with CrossSbtModule, but huge change in the build.sc :p

build.sc Outdated Show resolved Hide resolved
build.sc Outdated Show resolved Hide resolved
Copy link
Contributor

@edwardcwang edwardcwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

@jackkoenig jackkoenig added this to the 3.4.0 milestone Sep 2, 2020
@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Sep 2, 2020
@mergify mergify bot merged commit 29a71e0 into master Sep 2, 2020
@jackkoenig jackkoenig added Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. and removed Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. labels Sep 2, 2020
@sequencer sequencer deleted the mill_chisel_plugin branch January 16, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants