Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make svsim shutdown gracefully when the test throws an exception (backport #3309) #3310

Merged
merged 3 commits into from Jun 1, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 31, 2023

This is an automatic backport of pull request #3309 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com


Original PR Body

Type of Improvement

  • Bugfix

Release Notes

  • Fixed an issue where throwing an assert from an svsim simulation run may kill the simulated process before it can finish writing a waveform.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x or 3.6.x depending on impact, API modification or big change: 5.0.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@mergify mergify bot added the Backport Automated backport, please consider for minor release label May 31, 2023
@github-actions github-actions bot added the Bugfix Fixes a bug, will be included in release notes label May 31, 2023
jackkoenig and others added 2 commits June 1, 2023 12:56
The constructor is package private so user code cannot observe this
change.
@mergify mergify bot merged commit 5341bac into 5.x Jun 1, 2023
16 checks passed
@mergify mergify bot deleted the mergify/bp/5.x/pr-3309 branch June 1, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Automated backport, please consider for minor release Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants