Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support connecting Properties. #3481

Merged
merged 1 commit into from Aug 11, 2023
Merged

Conversation

mikeurbach
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

This includes the API, Chisel IR, Converter, FIRRTL IR, and Serializer support for Property connections.

It also includes moving requireVisible from Data to BaseType, which is required but was omitted from #3442.

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Property assignment is defined in FIRRTL spec version 3.1.0: https://github.com/chipsalliance/firrtl-spec/releases/tag/v3.1.0.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@mikeurbach mikeurbach added the Feature New feature, will be included in release notes label Aug 10, 2023
@mikeurbach mikeurbach added this to the 6.0 milestone Aug 10, 2023
@mikeurbach mikeurbach marked this pull request as draft August 10, 2023 23:08
@mikeurbach
Copy link
Contributor Author

Going to fix up the mdoc failure and make the new things private rather than marking them deprecated, which is just copy pasta.

@mikeurbach mikeurbach force-pushed the mikeurbach/properties-connect branch from ec48c16 to d156c1d Compare August 10, 2023 23:17
Copy link
Contributor

@mwachs5 mwachs5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me!

@mikeurbach mikeurbach merged commit ec75dec into main Aug 11, 2023
15 checks passed
@mikeurbach mikeurbach deleted the mikeurbach/properties-connect branch August 11, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants