Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sequences of Properties, including values. #3491

Merged
merged 1 commit into from Aug 16, 2023

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented Aug 15, 2023

This includes the API, Chisel IR, Converter, FIRRTL IR, and Serializer support for Seqs of Properties (and Property of Seq). This includes support for values are Seqs of Properties which themselves may or may not be literals.

TODO

  • add docs

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Feature New feature, will be included in release notes label Aug 15, 2023
@jackkoenig jackkoenig added this to the 6.0 milestone Aug 15, 2023
@jackkoenig jackkoenig force-pushed the sequence-properties branch 2 times, most recently from 54524ba to 7eeea28 Compare August 16, 2023 16:05
This includes the API, Chisel IR, Converter, FIRRTL IR, and Serializer
support for Seqs of Properties (and Property of Seq). This includes
support for values are Seqs of Properties which themselves may or may
not be literals.
Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks good to me!

@jackkoenig jackkoenig merged commit f6804a7 into main Aug 16, 2023
15 checks passed
@jackkoenig jackkoenig deleted the sequence-properties branch August 16, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants