Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Optionality of implicit clock and reset #3496

Merged
merged 1 commit into from Aug 18, 2023
Merged

Conversation

jackkoenig
Copy link
Contributor

This is in preparation for the new LTL operators defaulting to using the current in scope clock (needs Option[Clock]) and making it easy to disable clock for a region of assertions.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash

Release Notes

  • withClock, withReset, and withClockAndReset now have forms that take Option[Clock] and Option[Reset]
  • Module.clockOption and Module.resetOption return Option[Clock] and Option[Reset]

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

* withClock, withReset, and withClockAndReset now have forms that take
  Option[Clock] and Option[Reset]
* Module.clockOption and Module.resetOption return Option[Clock] and
  Option[Reset]
@jackkoenig jackkoenig added the Feature New feature, will be included in release notes label Aug 18, 2023
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is generally useful to be able to unset the clock/reset ignoring the LTL use case. 👍

@jackkoenig jackkoenig enabled auto-merge (squash) August 18, 2023 23:19
@jackkoenig jackkoenig merged commit 468cc3a into main Aug 18, 2023
18 checks passed
@jackkoenig jackkoenig deleted the none-clockandreset branch August 18, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants