add Path property type #3511
Merged
add Path property type #3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertchen-sifive
added
the
Feature
albertchen-sifive
requested review from
mikeurbach,
jackkoenig and
adkian-sifive
jackkoenig
reviewed
Aug 28, 2023
Comment on lines
38
to
42
| def apply(data: Data): PathType = { | ||
| new PathType { | ||
| def toTarget(): IsMember = data.toAbsoluteTarget | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm going to approve this as is, but we really validate at this point if the Data can have a target. I'm mainly thinking about things like PathType(3.U) which will result an an exception thrown later when .toAbsoluteTarget is actually called.
jackkoenig
reviewed
Aug 28, 2023
|
|
||
| /** Represent a Path type for referencing a hardware instance or member in a Property[PathType] | ||
| */ | ||
| sealed abstract class PathType { |
There was a problem hiding this comment.
Should this be PathType or perhaps just Path? It's Path in firrtl.
There was a problem hiding this comment.
renamed to Path
jackkoenig
approved these changes
Aug 28, 2023
|
Interesting. Maybe this is the real replacement to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src?Type of Improvement
Adds new public
PathTypeclass that represents a path to a hardware instance or member. AddsPathPropertyType/PathPropertyLiteralandPropertyTypeinstances for module/data/mem.Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.5.x,3.6.x, or5.xdepending on impact, API modification or big change:6.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.