Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate literals now materialize const wires #3515

Merged
merged 1 commit into from Aug 30, 2023
Merged

Aggregate literals now materialize const wires #3515

merged 1 commit into from Aug 30, 2023

Conversation

trilorez
Copy link
Contributor

This should be fairly innocuous change that was originally blocked by firtool's lack of const parsing support. This is a prerequisite for the more extensive const updates I've been working on.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Aggregate literals now materialize const wires. This will facilitate further support for const in operations and the type system in the future.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Backend Code Generation Affects backend code generation, will be included in release notes label Aug 30, 2023
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jackkoenig jackkoenig added this to the 6.0 milestone Aug 30, 2023
@jackkoenig jackkoenig enabled auto-merge (squash) August 30, 2023 21:05
@jackkoenig jackkoenig merged commit 9a64ac3 into chipsalliance:main Aug 30, 2023
17 of 18 checks passed
@trilorez trilorez deleted the const-aggregate-literals branch August 30, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Code Generation Affects backend code generation, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants