Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Fix link from Warnings to Cookbook #3524

Merged
merged 1 commit into from Sep 8, 2023
Merged

Conversation

jackkoenig
Copy link
Contributor

Done by adding a named anchor to the Cookbook to make linking easier. Also fix a minor issue with the website Makefile where stale markdown files could be left around and would not be overwritten when using the common alias cp alias cp -i.

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Documentation or website-related

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

Done by adding a named anchor to the Cookbook to make linking easier.
Also fix a minor issue with the website Makefile where stale markdown
files could be left around and would not be overwritten when using the
common alias cp alias `cp -i`.
@jackkoenig jackkoenig added the Documentation Only changing documentation label Sep 7, 2023
@jackkoenig jackkoenig merged commit 3abdb86 into main Sep 8, 2023
18 checks passed
@jackkoenig jackkoenig deleted the fix-warning-link branch September 8, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Only changing documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant