Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable checkConnect for Property types in MonoConnect. #3635

Merged
merged 2 commits into from Nov 16, 2023

Conversation

mikeurbach
Copy link
Contributor

@mikeurbach mikeurbach commented Nov 16, 2023

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Property types never actually called the helper that was factored out of MonoConnect specifically for them. Upon adding this, it turned out that they never had assignCompatDir called either, and this was leaving directions unspecified in aggregates. Both of these have probably lingered since Property types were made subclasses of Data again. This addresses both omissions, leading to earlier error checking for Property type connections.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@mikeurbach mikeurbach added the Bugfix Fixes a bug, will be included in release notes label Nov 16, 2023
@mikeurbach mikeurbach added this to the 6.0 milestone Nov 16, 2023
@mikeurbach mikeurbach marked this pull request as ready for review November 16, 2023 19:01
@mikeurbach mikeurbach requested review from jackkoenig, azidar and seldridge and removed request for jackkoenig and azidar November 16, 2023 19:12
@mikeurbach mikeurbach merged commit 0850a37 into main Nov 16, 2023
15 of 16 checks passed
@mikeurbach mikeurbach deleted the mikeurbach/properties-check-connect branch November 16, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property type connections are not checked by MonoConnect, and need their directions specified in Ports.
2 participants