Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share the globalNamespace in the DynamicContext used for Definition. #3700

Merged
merged 1 commit into from Jan 4, 2024

Conversation

mikeurbach
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Performance improvement

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

When creating large numbers of Definitions, copying the globalNamespace back and forth becomes a performance bottleneck.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@mikeurbach mikeurbach added the Performance Improves performance, will be included in release notes label Dec 21, 2023
When creating large numbers of Definitions, copying the
globalNamespace back and forth becomes a performance bottleneck.
@mikeurbach mikeurbach force-pushed the mikeurbach/namespace-copy-perf branch from e77422d to c380976 Compare January 4, 2024 21:15
@mikeurbach mikeurbach marked this pull request as ready for review January 4, 2024 21:16
@jackkoenig jackkoenig merged commit 511fc6f into main Jan 4, 2024
14 checks passed
@jackkoenig jackkoenig deleted the mikeurbach/namespace-copy-perf branch January 4, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Improves performance, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants